Commit abe25f3e authored by Willem de Bruijn's avatar Willem de Bruijn Committed by ZhangPeng
Browse files

fou: remove warn in gue_gro_receive on unsupported protocol 

stable inclusion
from stable-v6.6.47
commit 3db4395332e7050ef9ddeb3052e6b5019f2a2a59
bugzilla: https://gitee.com/openeuler/kernel/issues/IAHMJO

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=3db4395332e7050ef9ddeb3052e6b5019f2a2a59



--------------------------------

[ Upstream commit dd89a81d850fa9a65f67b4527c0e420d15bf836c ]

Drop the WARN_ON_ONCE inn gue_gro_receive if the encapsulated type is
not known or does not have a GRO handler.

Such a packet is easily constructed. Syzbot generates them and sets
off this warning.

Remove the warning as it is expected and not actionable.

The warning was previously reduced from WARN_ON to WARN_ON_ONCE in
commit 27013661 ("fou: Do WARN_ON_ONCE in gue_gro_receive for bad
proto callbacks").

Signed-off-by: default avatarWillem de Bruijn <willemb@google.com>
Reviewed-by: default avatarEric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/20240614122552.1649044-1-willemdebruijn.kernel@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarZhangPeng <zhangpeng362@huawei.com>
parent 3d366714

net/ipv4/fou_core.c

+1 −1
Original line number Diff line number Diff line
@@ -433,7 +433,7 @@ static struct sk_buff *gue_gro_receive(struct sock *sk, 


	offloads = NAPI_GRO_CB(skb)->is_ipv6 ? inet6_offloads : inet_offloads;

	ops = rcu_dereference(offloads[proto]);

	if (WARN_ON_ONCE(!ops || !ops->callbacks.gro_receive))

	if (!ops || !ops->callbacks.gro_receive)

		goto out;



	pp = call_gro_receive(ops->callbacks.gro_receive, head, skb);