Commit abdeb4fa authored by Benjamin Berg's avatar Benjamin Berg Committed by Richard Weinberger
Browse files

um: virtio_uml: move device breaking into workqueue 



We should not be calling virtio_break_device from an IRQ context.
Move breaking the device into the workqueue so that it is done from
a reasonable context.

Fixes: af9fb41e ("um: virtio_uml: Fix broken device handling in time-travel")
Signed-off-by: default avatarBenjamin Berg <benjamin.berg@intel.com>
Signed-off-by: default avatarRichard Weinberger <richard@nod.at>
parent 8e9cd851

arch/um/drivers/virtio_uml.c

+15 −1
Original line number Diff line number Diff line
@@ -170,7 +170,6 @@ static void vhost_user_check_reset(struct virtio_uml_device *vu_dev, 


	vu_dev->registered = 0;



	virtio_break_device(&vu_dev->vdev);

	schedule_work(&pdata->conn_broken_wk);

}
@@ -1138,6 +1137,15 @@ void virtio_uml_set_no_vq_suspend(struct virtio_device *vdev, 


static void vu_of_conn_broken(struct work_struct *wk)

{

	struct virtio_uml_platform_data *pdata;

	struct virtio_uml_device *vu_dev;



	pdata = container_of(wk, struct virtio_uml_platform_data, conn_broken_wk);



	vu_dev = platform_get_drvdata(pdata->pdev);



	virtio_break_device(&vu_dev->vdev);



	/*

	 * We can't remove the device from the devicetree so the only thing we

	 * can do is warn.
@@ -1268,8 +1276,14 @@ static int vu_unregister_cmdline_device(struct device *dev, void *data) 
static void vu_conn_broken(struct work_struct *wk)

{

	struct virtio_uml_platform_data *pdata;

	struct virtio_uml_device *vu_dev;



	pdata = container_of(wk, struct virtio_uml_platform_data, conn_broken_wk);



	vu_dev = platform_get_drvdata(pdata->pdev);



	virtio_break_device(&vu_dev->vdev);



	vu_unregister_cmdline_device(&pdata->pdev->dev, NULL);

}