Commit abaf94ec authored by Johannes Berg's avatar Johannes Berg
Browse files

nl80211: fix potential leak of ACL params 

In case nl80211_parse_unsol_bcast_probe_resp() results in an
error, need to "goto out" instead of just returning to free
possibly allocated data.

Fixes: 7443dcd1 ("nl80211: Unsolicited broadcast probe response support")
Link: https://lore.kernel.org/r/20210408142833.d8bc2e2e454a.If290b1ba85789726a671ff0b237726d4851b5b0f@changeid


Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent b5ac0146

net/wireless/nl80211.c

+2 −2
Original line number Diff line number Diff line
@@ -5,7 +5,7 @@ 
 * Copyright 2006-2010	Johannes Berg <johannes@sipsolutions.net>

 * Copyright 2013-2014  Intel Mobile Communications GmbH

 * Copyright 2015-2017	Intel Deutschland GmbH

 * Copyright (C) 2018-2020 Intel Corporation

 * Copyright (C) 2018-2021 Intel Corporation

 */



#include <linux/if.h>
@@ -5485,7 +5485,7 @@ static int nl80211_start_ap(struct sk_buff *skb, struct genl_info *info) 
			rdev, info->attrs[NL80211_ATTR_UNSOL_BCAST_PROBE_RESP],

			&params);

		if (err)

			return err;

			goto out;

	}



	nl80211_calculate_ap_params(&params);