Commit abac4259 authored by Luke D. Jones's avatar Luke D. Jones Committed by Hans de Goede
Browse files

platform/x86: asus-wmi: support setting mini-LED mode 



Support changing the mini-LED mode on some of the newer ASUS laptops.

Signed-off-by: default avatarLuke D. Jones <luke@ljones.dev>
Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20230630053552.976579-8-luke@ljones.dev


Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 609b3670

Documentation/ABI/testing/sysfs-platform-asus-wmi

+9 −0
Original line number Diff line number Diff line
@@ -117,3 +117,12 @@ Description: 
		Show if the egpu (XG Mobile) is correctly connected:

			* 0 - False,

			* 1 - True



What:		/sys/devices/platform/<platform>/mini_led_mode

Date:		Jun 2023

KernelVersion:	6.5

Contact:	"Luke Jones" <luke@ljones.dev>

Description:

		Change the mini-LED mode:

			* 0 - Single-zone,

			* 1 - Multi-zone

drivers/platform/x86/asus-wmi.c

+53 −0
Original line number Diff line number Diff line
@@ -265,6 +265,7 @@ struct asus_wmi { 
	bool battery_rsoc_available;



	bool panel_overdrive_available;

	bool mini_led_mode_available;



	struct hotplug_slot hotplug_slot;

	struct mutex hotplug_lock;
@@ -1820,6 +1821,54 @@ static ssize_t panel_od_store(struct device *dev, 
}

static DEVICE_ATTR_RW(panel_od);



/* Mini-LED mode **************************************************************/

static ssize_t mini_led_mode_show(struct device *dev,

				   struct device_attribute *attr, char *buf)

{

	struct asus_wmi *asus = dev_get_drvdata(dev);

	int result;



	result = asus_wmi_get_devstate_simple(asus, ASUS_WMI_DEVID_MINI_LED_MODE);

	if (result < 0)

		return result;



	return sysfs_emit(buf, "%d\n", result);

}



static ssize_t mini_led_mode_store(struct device *dev,

				    struct device_attribute *attr,

				    const char *buf, size_t count)

{

	int result, err;

	u32 mode;



	struct asus_wmi *asus = dev_get_drvdata(dev);



	result = kstrtou32(buf, 10, &mode);

	if (result)

		return result;



	if (mode > 1)

		return -EINVAL;



	err = asus_wmi_set_devstate(ASUS_WMI_DEVID_MINI_LED_MODE, mode, &result);



	if (err) {

		pr_warn("Failed to set mini-LED: %d\n", err);

		return err;

	}



	if (result > 1) {

		pr_warn("Failed to set mini-LED mode (result): 0x%x\n", result);

		return -EIO;

	}



	sysfs_notify(&asus->platform_device->dev.kobj, NULL, "mini_led_mode");



	return count;

}

static DEVICE_ATTR_RW(mini_led_mode);



/* Quirks *********************************************************************/



static void asus_wmi_set_xusb2pr(struct asus_wmi *asus)
@@ -3727,6 +3776,7 @@ static struct attribute *platform_attributes[] = { 
	&dev_attr_fan_boost_mode.attr,

	&dev_attr_throttle_thermal_policy.attr,

	&dev_attr_panel_od.attr,

	&dev_attr_mini_led_mode.attr,

	NULL

};
@@ -3764,6 +3814,8 @@ static umode_t asus_sysfs_is_visible(struct kobject *kobj, 
		ok = asus->throttle_thermal_policy_available;

	else if (attr == &dev_attr_panel_od.attr)

		ok = asus->panel_overdrive_available;

	else if (attr == &dev_attr_mini_led_mode.attr)

		ok = asus->mini_led_mode_available;



	if (devid != -1)

		ok = !(asus_wmi_get_devstate_simple(asus, devid) < 0);
@@ -4026,6 +4078,7 @@ static int asus_wmi_add(struct platform_device *pdev) 
	asus->kbd_rgb_mode_available = asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_TUF_RGB_MODE);

	asus->kbd_rgb_state_available = asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_TUF_RGB_STATE);

	asus->panel_overdrive_available = asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_PANEL_OD);

	asus->mini_led_mode_available = asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_MINI_LED_MODE);



	err = fan_boost_mode_check_present(asus);

	if (err)

include/linux/platform_data/x86/asus-wmi.h

+1 −0
Original line number Diff line number Diff line
@@ -66,6 +66,7 @@ 
#define ASUS_WMI_DEVID_CAMERA		0x00060013

#define ASUS_WMI_DEVID_LID_FLIP		0x00060062

#define ASUS_WMI_DEVID_LID_FLIP_ROG	0x00060077

#define ASUS_WMI_DEVID_MINI_LED_MODE	0x0005001E



/* Storage */

#define ASUS_WMI_DEVID_CARDREADER	0x00080013