Commit ab9ace34 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Saeed Mahameed
Browse files

net/mlx5: Use struct_size() helper in kvzalloc() 

Make use of the struct_size() helper instead of an open-coded version,
in order to avoid any potential type mistakes or integer overflows that,
in the worse scenario, could lead to heap overflows.

Link: https://github.com/KSPP/linux/issues/160


Signed-off-by: default avatarGustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 806bf340

drivers/net/ethernet/mellanox/mlx5/core/fs_counters.c

+1 −2
Original line number Diff line number Diff line
@@ -497,8 +497,7 @@ static struct mlx5_fc_bulk *mlx5_fc_bulk_create(struct mlx5_core_dev *dev) 
	alloc_bitmask = MLX5_CAP_GEN(dev, flow_counter_bulk_alloc);

	bulk_len = alloc_bitmask > 0 ? MLX5_FC_BULK_NUM_FCS(alloc_bitmask) : 1;



	bulk = kvzalloc(sizeof(*bulk) + bulk_len * sizeof(struct mlx5_fc),

			GFP_KERNEL);

	bulk = kvzalloc(struct_size(bulk, fcs, bulk_len), GFP_KERNEL);

	if (!bulk)

		goto err_alloc_bulk;