Commit ab3ee092 authored by Pierre-Louis Bossart's avatar Pierre-Louis Bossart Committed by Takashi Iwai
Browse files

ALSA: pci/rme9652/hdspm: remove always true condition 



Fix W=1 warning:

sound/pci/rme9652/hdspm.c: In function ‘hdspm_autosync_ref’:
sound/pci/rme9652/hdspm.c:3030:16: warning: comparison of unsigned
expression >= 0 is always true [-Wtype-limits]
 3030 |   if ((syncref >= HDSPM_AES32_AUTOSYNC_FROM_WORD) &&
      |                ^~

Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200702193604.169059-16-pierre-louis.bossart@linux.intel.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 6cdc01eb

sound/pci/rme9652/hdspm.c

+2 −2
Original line number Diff line number Diff line
@@ -3027,8 +3027,8 @@ static int hdspm_autosync_ref(struct hdspm *hdspm) 


		unsigned int status = hdspm_read(hdspm, HDSPM_statusRegister);

		unsigned int syncref = (status >> HDSPM_AES32_syncref_bit) & 0xF;

		if ((syncref >= HDSPM_AES32_AUTOSYNC_FROM_WORD) &&

				(syncref <= HDSPM_AES32_AUTOSYNC_FROM_SYNC_IN)) {

		/* syncref >= HDSPM_AES32_AUTOSYNC_FROM_WORD is always true */

		if (syncref <= HDSPM_AES32_AUTOSYNC_FROM_SYNC_IN) {

			return syncref;

		}

		return HDSPM_AES32_AUTOSYNC_FROM_NONE;