Commit ab382539 authored by Jan Kara's avatar Jan Kara Committed by Theodore Ts'o
Browse files

ext4: Update comment in mpage_prepare_extent_to_map() 



Since filemap_write_and_wait() is now enough to get journalled data to
final location update the comment in mpage_prepare_extent_to_map().

Signed-off-by: default avatarJan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20230329154950.19720-12-jack@suse.cz


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent 951cafa6

fs/ext4/inode.c

+4 −5
Original line number Diff line number Diff line
@@ -2496,11 +2496,10 @@ static int mpage_prepare_extent_to_map(struct mpage_da_data *mpd) 
			 * Just submit the page. For data=journal mode we

			 * first handle writeout of the page for checkpoint and

			 * only after that handle delayed page dirtying. This

			 * is crutial so that forcing a transaction commit and

			 * then calling filemap_write_and_wait() guarantees

			 * current state of data is in its final location. Such

			 * sequence is used for example by insert/collapse

			 * range operations before discarding the page cache.

			 * makes sure current data is checkpointed to the final

			 * location before possibly journalling it again which

			 * is desirable when the page is frequently dirtied

			 * through a pin.

			 */

			if (!mpd->can_map) {

				WARN_ON_ONCE(sb->s_writers.frozen ==