Commit ab372c22 authored by Dongliang Mu's avatar Dongliang Mu Committed by Stefan Schmidt
Browse files

ieee802154: hwsim: Fix possible memory leak in hwsim_subscribe_all_others 



In hwsim_subscribe_all_others, the error handling code performs
incorrectly if the second hwsim_alloc_edge fails. When this issue occurs,
it goes to sub_fail, without cleaning the edges allocated before.

Fixes: f25da51f ("ieee802154: hwsim: add replacement for fakelb")
Signed-off-by: default avatarDongliang Mu <mudongliangabcd@gmail.com>
Acked-by: default avatarAlexander Aring <aahringo@redhat.com>
Link: https://lore.kernel.org/r/20210611015812.1626999-1-mudongliangabcd@gmail.com


Signed-off-by: default avatarStefan Schmidt <stefan@datenfreihafen.org>
parent f2386cf7

drivers/net/ieee802154/mac802154_hwsim.c

+2 −2
Original line number Diff line number Diff line
@@ -715,6 +715,8 @@ static int hwsim_subscribe_all_others(struct hwsim_phy *phy) 


	return 0;



sub_fail:

	hwsim_edge_unsubscribe_me(phy);

me_fail:

	rcu_read_lock();

	list_for_each_entry_rcu(e, &phy->edges, list) {
@@ -722,8 +724,6 @@ static int hwsim_subscribe_all_others(struct hwsim_phy *phy) 
		hwsim_free_edge(e);

	}

	rcu_read_unlock();

sub_fail:

	hwsim_edge_unsubscribe_me(phy);

	return -ENOMEM;

}