Commit ab2463b2 authored by Yicong Yang's avatar Yicong Yang Committed by Zheng Zengkai
Browse files

spi: hisi-sfc-v3xx: fix potential irq race condition 

mainline inclusion
from mainline-v5.13-rc1
commit 4c84e42d
category: feature
bugzilla: https://gitee.com/openeuler/kernel/issues/I63WDM
CVE: NA

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4c84e42d29af



--------------------------------------------------------------------------

We mask the irq when the command completion is timeout. This won't
stop the already running irq handler. Use sychronize_irq() after
we mask the irq, to make sure there is no running handler.

Acked-by: default avatarJohn Garry <john.garry@huawei.com>
Signed-off-by: default avatarYicong Yang <yangyicong@hisilicon.com>
Link: https://lore.kernel.org/r/1618228708-37949-2-git-send-email-yangyicong@hisilicon.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Signed-off-by: default avatarWangming Shao <shaowangming@h-partners.com>
Reviewed-by: default avatarYicong Yang <yangyicong@huawei.com>
Signed-off-by: default avatarZheng Zengkai <zhengzengkai@huawei.com>
parent 012ba5cd

drivers/spi/spi-hisi-sfc-v3xx.c

+1 −0
Original line number Diff line number Diff line
@@ -342,6 +342,7 @@ static int hisi_sfc_v3xx_generic_exec_op(struct hisi_sfc_v3xx_host *host, 
			ret = 0;



		hisi_sfc_v3xx_disable_int(host);

		synchronize_irq(host->irq);

		host->completion = NULL;

	} else {

		ret = hisi_sfc_v3xx_wait_cmd_idle(host);