Commit ab2335da authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: ump: Drop redundant check of note-on with zero velocity 



The check of a note-on event with zero velocity is done twice, and the
latter one is superfluous.  Let's drop it.

Fixes: 0b5288f5 ("ALSA: ump: Add legacy raw MIDI support")
Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/4683198a-84f6-4238-9e87-c70667d84523@kili.mountain


Suggested-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/20230525083124.15277-1-tiwai@suse.de


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent dafb82e7

sound/core/ump_convert.c

+0 −3
Original line number Diff line number Diff line
@@ -340,9 +340,6 @@ static int cvt_legacy_cmd_to_ump(struct snd_ump_endpoint *ump, 


	switch (status) {

	case UMP_MSG_STATUS_NOTE_ON:

		if (!buf[2])

			status = UMP_MSG_STATUS_NOTE_OFF;

		fallthrough;

	case UMP_MSG_STATUS_NOTE_OFF:

		midi2->note.note = buf[1];

		midi2->note.velocity = upscale_7_to_16bit(buf[2]);