Commit aad98abd authored by Zhang Changzhong's avatar Zhang Changzhong Committed by Paolo Abeni
Browse files

sfc: fix potential memleak in __ef100_hard_start_xmit() 



The __ef100_hard_start_xmit() returns NETDEV_TX_OK without freeing skb
in error handling case, add dev_kfree_skb_any() to fix it.

Fixes: 51b35a45 ("sfc: skeleton EF100 PF driver")
Signed-off-by: default avatarZhang Changzhong <zhangchangzhong@huawei.com>
Acked-by: default avatarMartin Habets <habetsm.xilinx@gmail.com>
Reviewed-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Link: https://lore.kernel.org/r/1668671409-10909-1-git-send-email-zhangchangzhong@huawei.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent e541dd77

drivers/net/ethernet/sfc/ef100_netdev.c

+1 −0
Original line number Original line Diff line number Diff line
@@ -218,6 +218,7 @@ netdev_tx_t __ef100_hard_start_xmit(struct sk_buff *skb, 
		   skb->len, skb->data_len, channel->channel);

		   skb->len, skb->data_len, channel->channel);

	if (!efx->n_channels || !efx->n_tx_channels || !channel) {

	if (!efx->n_channels || !efx->n_tx_channels || !channel) {

		netif_stop_queue(net_dev);

		netif_stop_queue(net_dev);

		dev_kfree_skb_any(skb);

		goto err;

		goto err;

	}

	}