Unverified Commit aab5aaa7 authored by Maxime Ripard's avatar Maxime Ripard
Browse files

drm/connector: Only register TV mode property if present 



The drm_create_tv_properties() will create the TV mode property
unconditionally.

However, since we'll gradually phase it out, let's register it only if we
have a list passed as an argument. This will make the transition easier.

Acked-by: default avatarNoralf Trønnes <noralf@tronnes.org>
Tested-by: default avatarMateusz Kwiatkowski <kfyatek+publicgit@gmail.com>
Acked-in-principle-or-something-like-that-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Link: https://lore.kernel.org/r/20220728-rpi-analog-tv-properties-v10-3-256dad125326@cerno.tech


Signed-off-by: default avatarMaxime Ripard <maxime@cerno.tech>
parent 1fd4a5a3

drivers/gpu/drm/drm_connector.c

+11 −8
Original line number Diff line number Diff line
@@ -1690,6 +1690,8 @@ int drm_mode_create_tv_properties(struct drm_device *dev, 
	if (drm_mode_create_tv_margin_properties(dev))

		goto nomem;





	if (num_modes) {

		dev->mode_config.legacy_tv_mode_property =

			drm_property_create(dev, DRM_MODE_PROP_ENUM,

					    "mode", num_modes);
@@ -1699,6 +1701,7 @@ int drm_mode_create_tv_properties(struct drm_device *dev, 
		for (i = 0; i < num_modes; i++)

			drm_property_add_enum(dev->mode_config.legacy_tv_mode_property,

					      i, modes[i]);

	}



	dev->mode_config.tv_brightness_property =

		drm_property_create_range(dev, 0, "brightness", 0, 100);