Commit aab0b4fe authored by Samuel Holland's avatar Samuel Holland Committed by Wolfram Sang
Browse files

i2c: mv64xxx: Fix check for missing clock after adding RPM 



In commit e5c02cf5 ("i2c: mv64xxx: Add runtime PM support"), error
pointers to optional clocks were replaced by NULL to simplify the resume
callback implementation. However, that commit missed that the IS_ERR
check in mv64xxx_of_config should be replaced with a NULL check. As a
result, the check always passes, even for an invalid device tree.

Fixes: e5c02cf5 ("i2c: mv64xxx: Add runtime PM support")
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarSamuel Holland <samuel@sholland.org>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
parent a39bd92e

drivers/i2c/busses/i2c-mv64xxx.c

+1 −1
Original line number Diff line number Diff line
@@ -813,7 +813,7 @@ mv64xxx_of_config(struct mv64xxx_i2c_data *drv_data, 
	 * need to know tclk in order to calculate bus clock

	 * factors.

	 */

	if (IS_ERR(drv_data->clk)) {

	if (!drv_data->clk) {

		rc = -ENODEV;

		goto out;

	}