Commit aaae558d authored by Kemeng Shi's avatar Kemeng Shi Committed by Theodore Ts'o
Browse files

ext4: remove unnecessary check in ext4_mb_new_blocks 



1. remove unnecessary ac check:
We always go to out tag before ac is successfully allocated, then we can
move out tag after free of ac and remove NULL check of ac.

2. remove unnecessary *errp check:
We always go to errout tag if *errp is non-zero, then we can move errout
tag into error handle if *errp is non-zero.

Signed-off-by: default avatarKemeng Shi <shikemeng@huaweicloud.com>
Reviewed-by: default avatarOjaswin Mujoo <ojaswin@linux.ibm.com>
Link: https://lore.kernel.org/r/20230303172120.3800725-12-shikemeng@huaweicloud.com


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent 285164b8

fs/ext4/mballoc.c

+2 −3
Original line number Diff line number Diff line
@@ -5642,16 +5642,15 @@ ext4_fsblk_t ext4_mb_new_blocks(handle_t *handle, 
		*errp = -ENOSPC;

	}



errout:

	if (*errp) {

errout:

		ac->ac_b_ex.fe_len = 0;

		ar->len = 0;

		ext4_mb_show_ac(ac);

	}

	ext4_mb_release_context(ac);

out:

	if (ac)

	kmem_cache_free(ext4_ac_cachep, ac);

out:

	if (inquota && ar->len < inquota)

		dquot_free_block(ar->inode, EXT4_C2B(sbi, inquota - ar->len));

	if (!ar->len) {