Commit aa98d15e authored Mar 13, 2023 by Rahul Rameshbabu Committed by Jakub Kicinski Mar 15, 2023

net/mlx5e: Utilize the entire fifo



Previous check was comparing against the fifo mask. The mask is size of the
fifo (power of two) minus one, so a less than or equal comparator should be
used for checking if the fifo has room for the SKB.

Signed-off-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
Link: https://lore.kernel.org/r/20230314054234.267365-6-saeed@kernel.org


Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent c1fef618

drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -86,7 +86,7 @@ void mlx5e_free_txqsq_descs(struct mlx5e_txqsq *sq);
		static inline bool
		mlx5e_skb_fifo_has_room(struct mlx5e_skb_fifo *fifo)
		{
		return (u16)(fifo->pc - fifo->cc) < fifo->mask;
		return (u16)(fifo->pc - fifo->cc) <= fifo->mask;
		}

		static inline bool