Commit aa8ba13c authored by Qiushi Wu's avatar Qiushi Wu Committed by Alex Williamson
Browse files

vfio/mdev: Fix reference count leak in add_mdev_supported_type 



kobject_init_and_add() takes reference even when it fails.
If this function returns an error, kobject_put() must be called to
properly clean up the memory associated with the object. Thus,
replace kfree() by kobject_put() to fix this issue. Previous
commit "b8eb7183" fixed a similar problem.

Fixes: 7b96953b ("vfio: Mediated device Core driver")
Signed-off-by: default avatarQiushi Wu <wu000273@umn.edu>
Reviewed-by: default avatarCornelia Huck <cohuck@redhat.com>
Reviewed-by: default avatarKirti Wankhede <kwankhede@nvidia.com>
Signed-off-by: default avatarAlex Williamson <alex.williamson@redhat.com>
parent 9cb1fd0e

drivers/vfio/mdev/mdev_sysfs.c

+1 −1
Original line number Diff line number Diff line
@@ -110,7 +110,7 @@ static struct mdev_type *add_mdev_supported_type(struct mdev_parent *parent, 
				   "%s-%s", dev_driver_string(parent->dev),

				   group->name);

	if (ret) {

		kfree(type);

		kobject_put(&type->kobj);

		return ERR_PTR(ret);

	}