Commit aa3d18a3 authored by Thomas Zimmermann's avatar Thomas Zimmermann
Browse files

drm/vmwgfx: Don't set struct drm_device.irq_enabled 



The field drm_device.irq_enabled is only used by legacy drivers
with userspace modesetting. Don't set it in vmxgfx. All usage of
the field within vmwgfx can safely be removed.

Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: default avatarZack Rusin <zackr@vmware.com>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20210625082222.3845-26-tzimmermann@suse.de
parent 9ed64b1d

drivers/gpu/drm/vmwgfx/vmwgfx_irq.c

+0 −8
Original line number Diff line number Diff line
@@ -292,15 +292,11 @@ void vmw_irq_uninstall(struct drm_device *dev) 
	if (!(dev_priv->capabilities & SVGA_CAP_IRQMASK))

		return;



	if (!dev->irq_enabled)

		return;



	vmw_write(dev_priv, SVGA_REG_IRQMASK, 0);



	status = vmw_irq_status_read(dev_priv);

	vmw_irq_status_write(dev_priv, status);



	dev->irq_enabled = false;

	free_irq(dev->irq, dev);

}
@@ -315,9 +311,6 @@ int vmw_irq_install(struct drm_device *dev, int irq) 
{

	int ret;



	if (dev->irq_enabled)

		return -EBUSY;



	vmw_irq_preinstall(dev);



	ret = request_threaded_irq(irq, vmw_irq_handler, vmw_thread_fn,
@@ -325,7 +318,6 @@ int vmw_irq_install(struct drm_device *dev, int irq) 
	if (ret < 0)

		return ret;



	dev->irq_enabled = true;

	dev->irq = irq;



	return ret;