Unverified Commit aa196597 authored by Hsin-Yi Wang's avatar Hsin-Yi Wang Committed by Robert Foss
Browse files

drm/bridge: anx7625: use pm_runtime_force_suspend(resume) 



There's no need to check for IRQ or disable it in suspend.

Use pm_runtime_force_suspend(resume) to make sure anx7625 is powered off
correctly. Make the system suspend/resume and pm runtime suspend/resume
more consistent.

Signed-off-by: default avatarHsin-Yi Wang <hsinyi@chromium.org>
Reviewed-by: default avatarXin Ji <xji@analogixsemi.com>
Signed-off-by: default avatarRobert Foss <robert.foss@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20220706125254.2474095-3-hsinyi@chromium.org
parent e660916b

drivers/gpu/drm/bridge/analogix/anx7625.c

+2 −31
Original line number Diff line number Diff line
@@ -2504,38 +2504,9 @@ static int __maybe_unused anx7625_runtime_pm_resume(struct device *dev) 
	return 0;

}



static int __maybe_unused anx7625_resume(struct device *dev)

{

	struct anx7625_data *ctx = dev_get_drvdata(dev);



	if (!ctx->pdata.intp_irq)

		return 0;



	if (!pm_runtime_enabled(dev) || !pm_runtime_suspended(dev)) {

		enable_irq(ctx->pdata.intp_irq);

		anx7625_runtime_pm_resume(dev);

	}



	return 0;

}



static int __maybe_unused anx7625_suspend(struct device *dev)

{

	struct anx7625_data *ctx = dev_get_drvdata(dev);



	if (!ctx->pdata.intp_irq)

		return 0;



	if (!pm_runtime_enabled(dev) || !pm_runtime_suspended(dev)) {

		anx7625_runtime_pm_suspend(dev);

		disable_irq(ctx->pdata.intp_irq);

	}



	return 0;

}



static const struct dev_pm_ops anx7625_pm_ops = {

	SET_SYSTEM_SLEEP_PM_OPS(anx7625_suspend, anx7625_resume)

	SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,

				pm_runtime_force_resume)

	SET_RUNTIME_PM_OPS(anx7625_runtime_pm_suspend,

			   anx7625_runtime_pm_resume, NULL)

};