Commit aa1262ca authored by Srinivas Kandagatla's avatar Srinivas Kandagatla Committed by Vinod Koul
Browse files

soundwire: qcom: Check device status before reading devid 



As per hardware datasheet its recommended that we check the device
status before reading devid assigned by auto-enumeration.

Without this patch we see SoundWire devices with invalid enumeration
addresses on the bus.

Cc: stable@vger.kernel.org
Fixes: a6e65819 ("soundwire: qcom: add auto enumeration support")
Signed-off-by: default avatarSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20220706095644.5852-1-srinivas.kandagatla@linaro.org


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 1fd0d85a

drivers/soundwire/qcom.c

+4 −0
Original line number Diff line number Diff line
@@ -474,6 +474,10 @@ static int qcom_swrm_enumerate(struct sdw_bus *bus) 
	char *buf1 = (char *)&val1, *buf2 = (char *)&val2;



	for (i = 1; i <= SDW_MAX_DEVICES; i++) {

		/* do not continue if the status is Not Present  */

		if (!ctrl->status[i])

			continue;



		/*SCP_Devid5 - Devid 4*/

		ctrl->reg_read(ctrl, SWRM_ENUMERATOR_SLAVE_DEV_ID_1(i), &val1);