Commit aa07d34d authored by Ville Syrjälä's avatar Ville Syrjälä
Browse files

drm/i915: Pimp DPLL ref/unref debugs 



We currently have a debug message in intel_reference_shared_dpll()
but no counterpart in intel_unreference_shared_dpll(). Add one.

Switch to the [CRTC:...] notation for the pipe name while at it.

v2: Use drm_dbg_kms() instead of drm_dbg() (Jani)

Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220922191350.4303-1-ville.syrjala@linux.intel.com


Reviewed-by: default avatarJani Nikula <jani.nikula@intel.com>
parent fea1beb6

drivers/gpu/drm/i915/display/intel_dpll_mgr.c

+8 −3
Original line number Diff line number Diff line
@@ -384,20 +384,25 @@ intel_reference_shared_dpll(struct intel_atomic_state *state, 
	if (shared_dpll[id].pipe_mask == 0)

		shared_dpll[id].hw_state = *pll_state;



	drm_dbg(&i915->drm, "using %s for pipe %c\n", pll->info->name,

		pipe_name(crtc->pipe));



	shared_dpll[id].pipe_mask |= BIT(crtc->pipe);



	drm_dbg_kms(&i915->drm, "[CRTC:%d:%s] reserving %s\n",

		    crtc->base.base.id, crtc->base.name, pll->info->name);

}



static void intel_unreference_shared_dpll(struct intel_atomic_state *state,

					  const struct intel_crtc *crtc,

					  const struct intel_shared_dpll *pll)

{

	struct drm_i915_private *i915 = to_i915(state->base.dev);

	struct intel_shared_dpll_state *shared_dpll;



	shared_dpll = intel_atomic_get_shared_dpll_state(&state->base);



	shared_dpll[pll->info->id].pipe_mask &= ~BIT(crtc->pipe);



	drm_dbg_kms(&i915->drm, "[CRTC:%d:%s] releasing %s\n",

		    crtc->base.base.id, crtc->base.name, pll->info->name);

}



static void intel_put_dpll(struct intel_atomic_state *state,