Commit a9d1c250 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Hans de Goede
Browse files

platform/x86: i2c-multi-instantiate: Simplify with dev_err_probe() 



Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20201105110530.27888-2-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 6c328c34

drivers/platform/x86/i2c-multi-instantiate.c

+2 −3
Original line number Diff line number Diff line
@@ -118,9 +118,8 @@ static int i2c_multi_inst_probe(struct platform_device *pdev) 
		}

		multi->clients[i] = i2c_acpi_new_device(dev, i, &board_info);

		if (IS_ERR(multi->clients[i])) {

			ret = PTR_ERR(multi->clients[i]);

			if (ret != -EPROBE_DEFER)

				dev_err(dev, "Error creating i2c-client, idx %d\n", i);

			ret = dev_err_probe(dev, PTR_ERR(multi->clients[i]),

					    "Error creating i2c-client, idx %d\n", i);

			goto error;

		}

	}