Commit a9ca9bb3 authored by Tian Tao's avatar Tian Tao Committed by Alex Deucher
Browse files

drm/amd/pm: Convert sysfs sprintf/snprintf family to sysfs_emit 



Fix the following coccicheck warning:
drivers/gpu/drm/amd/pm/amdgpu_pm.c:1940:8-16: WARNING:
use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:1978:8-16: WARNING:
use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:2022:8-16: WARNING:
use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:294:8-16: WARNING:
use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:154:8-16: WARNING:
use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:496:8-16: WARNING:
use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:512:9-17: WARNING:
use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:1740:8-16: WARNING:
use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:1667:8-16: WARNING:
use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:2074:8-16: WARNING:
use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:2047:9-17: WARNING:
use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:2768:8-16: WARNING:
use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:2738:8-16: WARNING:
use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:2442:8-16: WARNING:
use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:3246:8-16: WARNING:
use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:3253:8-16: WARNING:
use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:2458:8-16: WARNING:
use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:3047:8-16: WARNING:
use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:3133:8-16: WARNING:
use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:3209:8-16: WARNING:
use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:3216:8-16: WARNING:
use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:2410:8-16: WARNING:
use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:2496:8-16: WARNING:
use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:2470:8-16: WARNING:
use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:2426:8-16: WARNING:
use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:2965:8-16: WARNING:
use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:2972:8-16: WARNING:
use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:3006:8-16: WARNING:
use scnprintf or sprintf
drivers/gpu/drm/amd/pm/amdgpu_pm.c:3013:8-16: WARNING:
use scnprintf or sprintf

Signed-off-by: default avatarTian Tao <tiantao6@hisilicon.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 36000c7a

drivers/gpu/drm/amd/pm/amdgpu_pm.c

+45 −45
Original line number Diff line number Diff line
@@ -146,7 +146,7 @@ static ssize_t amdgpu_get_power_dpm_state(struct device *dev, 
	pm_runtime_mark_last_busy(ddev->dev);

	pm_runtime_put_autosuspend(ddev->dev);



	return snprintf(buf, PAGE_SIZE, "%s\n",

	return sysfs_emit(buf, "%s\n",

			  (pm == POWER_STATE_TYPE_BATTERY) ? "battery" :

			  (pm == POWER_STATE_TYPE_BALANCED) ? "balanced" : "performance");

}
@@ -288,7 +288,7 @@ static ssize_t amdgpu_get_power_dpm_force_performance_level(struct device *dev, 
	pm_runtime_mark_last_busy(ddev->dev);

	pm_runtime_put_autosuspend(ddev->dev);



	return snprintf(buf, PAGE_SIZE, "%s\n",

	return sysfs_emit(buf, "%s\n",

			  (level == AMD_DPM_FORCED_LEVEL_AUTO) ? "auto" :

			  (level == AMD_DPM_FORCED_LEVEL_LOW) ? "low" :

			  (level == AMD_DPM_FORCED_LEVEL_HIGH) ? "high" :
@@ -483,7 +483,7 @@ static ssize_t amdgpu_get_pp_cur_state(struct device *dev, 
	if (i == data.nums)

		i = -EINVAL;



	return snprintf(buf, PAGE_SIZE, "%d\n", i);

	return sysfs_emit(buf, "%d\n", i);

}



static ssize_t amdgpu_get_pp_force_state(struct device *dev,
@@ -501,7 +501,7 @@ static ssize_t amdgpu_get_pp_force_state(struct device *dev, 
	if (adev->pp_force_state_enabled)

		return amdgpu_get_pp_cur_state(dev, attr, buf);

	else

		return snprintf(buf, PAGE_SIZE, "\n");

		return sysfs_emit(buf, "\n");

}



static ssize_t amdgpu_set_pp_force_state(struct device *dev,
@@ -1280,7 +1280,7 @@ static ssize_t amdgpu_get_pp_sclk_od(struct device *dev, 
	pm_runtime_mark_last_busy(ddev->dev);

	pm_runtime_put_autosuspend(ddev->dev);



	return snprintf(buf, PAGE_SIZE, "%d\n", value);

	return sysfs_emit(buf, "%d\n", value);

}



static ssize_t amdgpu_set_pp_sclk_od(struct device *dev,
@@ -1357,7 +1357,7 @@ static ssize_t amdgpu_get_pp_mclk_od(struct device *dev, 
	pm_runtime_mark_last_busy(ddev->dev);

	pm_runtime_put_autosuspend(ddev->dev);



	return snprintf(buf, PAGE_SIZE, "%d\n", value);

	return sysfs_emit(buf, "%d\n", value);

}



static ssize_t amdgpu_set_pp_mclk_od(struct device *dev,
@@ -1561,7 +1561,7 @@ static ssize_t amdgpu_get_gpu_busy_percent(struct device *dev, 
	if (r)

		return r;



	return snprintf(buf, PAGE_SIZE, "%d\n", value);

	return sysfs_emit(buf, "%d\n", value);

}



/**
@@ -1601,7 +1601,7 @@ static ssize_t amdgpu_get_mem_busy_percent(struct device *dev, 
	if (r)

		return r;



	return snprintf(buf, PAGE_SIZE, "%d\n", value);

	return sysfs_emit(buf, "%d\n", value);

}



/**
@@ -1647,7 +1647,7 @@ static ssize_t amdgpu_get_pcie_bw(struct device *dev, 
	pm_runtime_mark_last_busy(ddev->dev);

	pm_runtime_put_autosuspend(ddev->dev);



	return snprintf(buf, PAGE_SIZE,	"%llu %llu %i\n",

	return sysfs_emit(buf, "%llu %llu %i\n",

			  count0, count1, pcie_get_mps(adev->pdev));

}
@@ -1674,7 +1674,7 @@ static ssize_t amdgpu_get_unique_id(struct device *dev, 
		return -EPERM;



	if (adev->unique_id)

		return snprintf(buf, PAGE_SIZE, "%016llx\n", adev->unique_id);

		return sysfs_emit(buf, "%016llx\n", adev->unique_id);



	return 0;

}
@@ -1701,7 +1701,7 @@ static ssize_t amdgpu_get_thermal_throttling_logging(struct device *dev, 
	struct drm_device *ddev = dev_get_drvdata(dev);

	struct amdgpu_device *adev = drm_to_adev(ddev);



	return snprintf(buf, PAGE_SIZE, "%s: thermal throttling logging %s, with interval %d seconds\n",

	return sysfs_emit(buf, "%s: thermal throttling logging %s, with interval %d seconds\n",

			  adev_to_drm(adev)->unique,

			  atomic_read(&adev->throttling_logging_enabled) ? "enabled" : "disabled",

			  adev->throttling_logging_rs.interval / HZ + 1);
@@ -2039,7 +2039,7 @@ static ssize_t amdgpu_hwmon_show_temp(struct device *dev, 
	if (r)

		return r;



	return snprintf(buf, PAGE_SIZE, "%d\n", temp);

	return sysfs_emit(buf, "%d\n", temp);

}



static ssize_t amdgpu_hwmon_show_temp_thresh(struct device *dev,
@@ -2055,7 +2055,7 @@ static ssize_t amdgpu_hwmon_show_temp_thresh(struct device *dev, 
	else

		temp = adev->pm.dpm.thermal.max_temp;



	return snprintf(buf, PAGE_SIZE, "%d\n", temp);

	return sysfs_emit(buf, "%d\n", temp);

}



static ssize_t amdgpu_hwmon_show_hotspot_temp_thresh(struct device *dev,
@@ -2071,7 +2071,7 @@ static ssize_t amdgpu_hwmon_show_hotspot_temp_thresh(struct device *dev, 
	else

		temp = adev->pm.dpm.thermal.max_hotspot_crit_temp;



	return snprintf(buf, PAGE_SIZE, "%d\n", temp);

	return sysfs_emit(buf, "%d\n", temp);

}



static ssize_t amdgpu_hwmon_show_mem_temp_thresh(struct device *dev,
@@ -2087,7 +2087,7 @@ static ssize_t amdgpu_hwmon_show_mem_temp_thresh(struct device *dev, 
	else

		temp = adev->pm.dpm.thermal.max_mem_crit_temp;



	return snprintf(buf, PAGE_SIZE, "%d\n", temp);

	return sysfs_emit(buf, "%d\n", temp);

}



static ssize_t amdgpu_hwmon_show_temp_label(struct device *dev,
@@ -2099,7 +2099,7 @@ static ssize_t amdgpu_hwmon_show_temp_label(struct device *dev, 
	if (channel >= PP_TEMP_MAX)

		return -EINVAL;



	return snprintf(buf, PAGE_SIZE, "%s\n", temp_label[channel].label);

	return sysfs_emit(buf, "%s\n", temp_label[channel].label);

}



static ssize_t amdgpu_hwmon_show_temp_emergency(struct device *dev,
@@ -2125,7 +2125,7 @@ static ssize_t amdgpu_hwmon_show_temp_emergency(struct device *dev, 
		break;

	}



	return snprintf(buf, PAGE_SIZE, "%d\n", temp);

	return sysfs_emit(buf, "%d\n", temp);

}



static ssize_t amdgpu_hwmon_get_pwm1_enable(struct device *dev,
@@ -2361,7 +2361,7 @@ static ssize_t amdgpu_hwmon_get_fan1_min(struct device *dev, 
	if (r)

		return r;



	return snprintf(buf, PAGE_SIZE, "%d\n", min_rpm);

	return sysfs_emit(buf, "%d\n", min_rpm);

}



static ssize_t amdgpu_hwmon_get_fan1_max(struct device *dev,
@@ -2393,7 +2393,7 @@ static ssize_t amdgpu_hwmon_get_fan1_max(struct device *dev, 
	if (r)

		return r;



	return snprintf(buf, PAGE_SIZE, "%d\n", max_rpm);

	return sysfs_emit(buf, "%d\n", max_rpm);

}



static ssize_t amdgpu_hwmon_get_fan1_target(struct device *dev,
@@ -2585,14 +2585,14 @@ static ssize_t amdgpu_hwmon_show_vddgfx(struct device *dev, 
	if (r)

		return r;



	return snprintf(buf, PAGE_SIZE, "%d\n", vddgfx);

	return sysfs_emit(buf, "%d\n", vddgfx);

}



static ssize_t amdgpu_hwmon_show_vddgfx_label(struct device *dev,

					      struct device_attribute *attr,

					      char *buf)

{

	return snprintf(buf, PAGE_SIZE, "vddgfx\n");

	return sysfs_emit(buf, "vddgfx\n");

}



static ssize_t amdgpu_hwmon_show_vddnb(struct device *dev,
@@ -2628,14 +2628,14 @@ static ssize_t amdgpu_hwmon_show_vddnb(struct device *dev, 
	if (r)

		return r;



	return snprintf(buf, PAGE_SIZE, "%d\n", vddnb);

	return sysfs_emit(buf, "%d\n", vddnb);

}



static ssize_t amdgpu_hwmon_show_vddnb_label(struct device *dev,

					      struct device_attribute *attr,

					      char *buf)

{

	return snprintf(buf, PAGE_SIZE, "vddnb\n");

	return sysfs_emit(buf, "vddnb\n");

}



static ssize_t amdgpu_hwmon_show_power_avg(struct device *dev,
@@ -2671,7 +2671,7 @@ static ssize_t amdgpu_hwmon_show_power_avg(struct device *dev, 
	/* convert to microwatts */

	uw = (query >> 8) * 1000000 + (query & 0xff) * 1000;



	return snprintf(buf, PAGE_SIZE, "%u\n", uw);

	return sysfs_emit(buf, "%u\n", uw);

}



static ssize_t amdgpu_hwmon_show_power_cap_min(struct device *dev,
@@ -2804,7 +2804,7 @@ static ssize_t amdgpu_hwmon_show_power_label(struct device *dev, 
{

	int limit_type = to_sensor_dev_attr(attr)->index;



	return snprintf(buf, PAGE_SIZE, "%s\n",

	return sysfs_emit(buf, "%s\n",

		limit_type == SMU_FAST_PPT_LIMIT ? "fastPPT" : "slowPPT");

}
@@ -2883,14 +2883,14 @@ static ssize_t amdgpu_hwmon_show_sclk(struct device *dev, 
	if (r)

		return r;



	return snprintf(buf, PAGE_SIZE, "%u\n", sclk * 10 * 1000);

	return sysfs_emit(buf, "%u\n", sclk * 10 * 1000);

}



static ssize_t amdgpu_hwmon_show_sclk_label(struct device *dev,

					    struct device_attribute *attr,

					    char *buf)

{

	return snprintf(buf, PAGE_SIZE, "sclk\n");

	return sysfs_emit(buf, "sclk\n");

}



static ssize_t amdgpu_hwmon_show_mclk(struct device *dev,
@@ -2922,14 +2922,14 @@ static ssize_t amdgpu_hwmon_show_mclk(struct device *dev, 
	if (r)

		return r;



	return snprintf(buf, PAGE_SIZE, "%u\n", mclk * 10 * 1000);

	return sysfs_emit(buf, "%u\n", mclk * 10 * 1000);

}



static ssize_t amdgpu_hwmon_show_mclk_label(struct device *dev,

					    struct device_attribute *attr,

					    char *buf)

{

	return snprintf(buf, PAGE_SIZE, "mclk\n");

	return sysfs_emit(buf, "mclk\n");

}



/**