Commit a9afc3e4 authored by Vladimir Oltean's avatar Vladimir Oltean Committed by Jakub Kicinski
Browse files

net: dsa: felix: remove confusing/incorrect comment from felix_setup() 



That comment was written prior to knowing that what I was actually
seeing was a manifestation of the bug fixed in commit b4024c9e
("felix: Fix initialization of ioremap resources").

There isn't any particular reason now why the hardware initialization is
done in felix_setup(), so just delete that comment to avoid spreading
misinformation.

Signed-off-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 93f0f93b

drivers/net/dsa/ocelot/felix.c

+0 −5
Original line number Diff line number Diff line
@@ -1550,11 +1550,6 @@ static int felix_connect_tag_protocol(struct dsa_switch *ds, 
	}

}



/* Hardware initialization done here so that we can allocate structures with

 * devm without fear of dsa_register_switch returning -EPROBE_DEFER and causing

 * us to allocate structures twice (leak memory) and map PCI memory twice

 * (which will not work).

 */

static int felix_setup(struct dsa_switch *ds)

{

	struct ocelot *ocelot = ds->priv;