Commit a9aefd70 authored by Alexey Khoroshilov's avatar Alexey Khoroshilov Committed by Steven Whitehouse
Browse files

GFS2: fix error propagation in init_threads() 



If kthread_run() fails, init_threads() returns
IS_ERR(p) instead of PTR_ERR(p).

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: default avatarAlexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
parent edd2e9ac

fs/gfs2/ops_fstype.c

+4 −4
Original line number Diff line number Diff line
@@ -916,16 +916,16 @@ static int init_threads(struct gfs2_sbd *sdp, int undo) 
		goto fail_quotad;



	p = kthread_run(gfs2_logd, sdp, "gfs2_logd");

	error = IS_ERR(p);

	if (error) {

	if (IS_ERR(p)) {

		error = PTR_ERR(p);

		fs_err(sdp, "can't start logd thread: %d\n", error);

		return error;

	}

	sdp->sd_logd_process = p;



	p = kthread_run(gfs2_quotad, sdp, "gfs2_quotad");

	error = IS_ERR(p);

	if (error) {

	if (IS_ERR(p)) {

		error = PTR_ERR(p);

		fs_err(sdp, "can't start quotad thread: %d\n", error);

		goto fail;

	}