Commit a9ab9cce authored by Paul E. McKenney's avatar Paul E. McKenney
Browse files

rcu-tasks: Don't delete holdouts within trc_wait_for_one_reader()



Invoking trc_del_holdout() from within trc_wait_for_one_reader() is
only a performance optimization because the RCU Tasks Trace grace-period
kthread will eventually do this within check_all_holdout_tasks_trace().
But it is not a particularly important performance optimization because
it only applies to the grace-period kthread, of which there is but one.
This commit therefore removes this invocation of trc_del_holdout() in
favor of the one in check_all_holdout_tasks_trace() in the grace-period
kthread.

Reported-by: default avatar"Xu, Yanfei" <yanfei.xu@windriver.com>
Signed-off-by: default avatarPaul E. McKenney <paulmck@kernel.org>
parent 1d10bf55
Loading
Loading
Loading
Loading
+0 −1
Original line number Diff line number Diff line
@@ -982,7 +982,6 @@ static void trc_wait_for_one_reader(struct task_struct *t,
	// The current task had better be in a quiescent state.
	if (t == current) {
		t->trc_reader_checked = true;
		trc_del_holdout(t);
		WARN_ON_ONCE(t->trc_reader_nesting);
		return;
	}