Commit a9a27d4a authored by Namjae Jeon's avatar Namjae Jeon
Browse files

ksmbd: don't set FILE DELETE and FILE_DELETE_CHILD in access mask by default 



When there is no dacl in request, ksmbd send dacl that coverted by using
file permission. This patch don't set FILE DELETE and FILE_DELETE_CHILD
in access mask by default.

Signed-off-by: default avatarNamjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent 29668d7e

fs/ksmbd/smbacl.c

+0 −2
Original line number Diff line number Diff line
@@ -731,7 +731,6 @@ static void set_mode_dacl(struct user_namespace *user_ns, 
	ace_size = fill_ace_for_sid(pace, sid, ACCESS_ALLOWED, 0,

				    fattr->cf_mode, 0700);

	pace->sid.sub_auth[pace->sid.num_subauth++] = cpu_to_le32(uid);

	pace->access_req |= FILE_DELETE_LE | FILE_DELETE_CHILD_LE;

	pace->size = cpu_to_le16(ace_size + 4);

	size += le16_to_cpu(pace->size);

	pace = (struct smb_ace *)((char *)pndace + size);
@@ -752,7 +751,6 @@ static void set_mode_dacl(struct user_namespace *user_ns, 
		/* creator owner */

		size += fill_ace_for_sid(pace, &creator_owner, ACCESS_ALLOWED,

					 0x0b, fattr->cf_mode, 0700);

		pace->access_req |= FILE_DELETE_LE | FILE_DELETE_CHILD_LE;

		pace = (struct smb_ace *)((char *)pndace + size);



		/* creator group */