Commit a99d76f9 authored by Jingoo Han's avatar Jingoo Han Committed by Bryan Wu
Browse files

leds: leds-gpio: use gpio_request_one 



Using gpio_request_one can make the code simpler because it can
set the direction and initial value in one shot.

Signed-off-by: default avatarJingoo Han <jg1.han@samsung.com>
Signed-off-by: default avatarBryan Wu <cooloney@gmail.com>
parent 14ce82e5

drivers/leds/leds-gpio.c

+5 −7
Original line number Diff line number Diff line
@@ -106,10 +106,6 @@ static int __devinit create_gpio_led(const struct gpio_led *template, 
		return 0;

	}



	ret = gpio_request(template->gpio, template->name);

	if (ret < 0)

		return ret;



	led_dat->cdev.name = template->name;

	led_dat->cdev.default_trigger = template->default_trigger;

	led_dat->gpio = template->gpio;
@@ -129,9 +125,11 @@ static int __devinit create_gpio_led(const struct gpio_led *template, 
	if (!template->retain_state_suspended)

		led_dat->cdev.flags |= LED_CORE_SUSPENDRESUME;



	ret = gpio_direction_output(led_dat->gpio, led_dat->active_low ^ state);

	ret = gpio_request_one(template->gpio,

			GPIOF_DIR_OUT | (led_dat->active_low ^ state),

			template->name);

	if (ret < 0)

		goto err;

		return ret;



	INIT_WORK(&led_dat->work, gpio_led_work);