Commit a99a3e2e authored by Eric W. Biederman's avatar Eric W. Biederman
Browse files

coredump: Move definition of struct coredump_params into coredump.h 



Move the definition of struct coredump_params into coredump.h where
it belongs.

Remove the slightly errorneous comment explaining why struct
coredump_params was declared in binfmts.h.

Signed-off-by: default avatar"Eric W. Biederman" <ebiederm@xmission.com>
parent 9e1a3ce0

fs/binfmt_flat.c

+1 −0
Original line number Diff line number Diff line
@@ -37,6 +37,7 @@ 
#include <linux/flat.h>

#include <linux/uaccess.h>

#include <linux/vmalloc.h>

#include <linux/coredump.h>



#include <asm/byteorder.h>

#include <asm/unaligned.h>

include/linux/binfmts.h

+1 −12
Original line number Diff line number Diff line
@@ -8,6 +8,7 @@ 
#include <uapi/linux/binfmts.h>



struct filename;

struct coredump_params;



#define CORENAME_MAX_SIZE 128
@@ -77,18 +78,6 @@ struct linux_binprm { 
#define BINPRM_FLAGS_PRESERVE_ARGV0_BIT 3

#define BINPRM_FLAGS_PRESERVE_ARGV0 (1 << BINPRM_FLAGS_PRESERVE_ARGV0_BIT)



/* Function parameter for binfmt->coredump */

struct coredump_params {

	const kernel_siginfo_t *siginfo;

	struct pt_regs *regs;

	struct file *file;

	unsigned long limit;

	unsigned long mm_flags;

	loff_t written;

	loff_t pos;

	loff_t to_skip;

};



/*

 * This structure defines the functions that are used to load the binary formats that

 * linux accepts.

include/linux/coredump.h

+11 −1
Original line number Diff line number Diff line
@@ -14,11 +14,21 @@ struct core_vma_metadata { 
	unsigned long dump_size;

};



struct coredump_params {

	const kernel_siginfo_t *siginfo;

	struct pt_regs *regs;

	struct file *file;

	unsigned long limit;

	unsigned long mm_flags;

	loff_t written;

	loff_t pos;

	loff_t to_skip;

};



/*

 * These are the only things you should do on a core-file: use only these

 * functions to write out all the necessary info.

 */

struct coredump_params;

extern void dump_skip_to(struct coredump_params *cprm, unsigned long to);

extern void dump_skip(struct coredump_params *cprm, size_t nr);

extern int dump_emit(struct coredump_params *cprm, const void *addr, int nr);