Commit a98c2183 authored by Manivannan Sadhasivam's avatar Manivannan Sadhasivam Committed by Martin K. Petersen
Browse files

scsi: ufs: ufs-qcom: Remove unnecessary WARN_ON() 



In the reset assert and deassert callbacks, the supplied "id" is not used
at all and only the HBA reset is performed all the time. So there is no
reason to use a WARN_ON() on the "id".

Reviewed-by: default avatarAndrew Halaney <ahalaney@redhat.com>
Reviewed-by: default avatarAsutosh Das <quic_asutoshd@quicinc.com>
Tested-by: Andrew Halaney <ahalaney@redhat.com> # Qdrive3/sa8540p-ride
Signed-off-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 031312db

drivers/ufs/host/ufs-qcom.c

+0 −4
Original line number Diff line number Diff line
@@ -886,8 +886,6 @@ ufs_qcom_reset_assert(struct reset_controller_dev *rcdev, unsigned long id) 
{

	struct ufs_qcom_host *host = rcdev_to_ufs_host(rcdev);



	/* Currently this code only knows about a single reset. */

	WARN_ON(id);

	ufs_qcom_assert_reset(host->hba);

	/* provide 1ms delay to let the reset pulse propagate. */

	usleep_range(1000, 1100);
@@ -899,8 +897,6 @@ ufs_qcom_reset_deassert(struct reset_controller_dev *rcdev, unsigned long id) 
{

	struct ufs_qcom_host *host = rcdev_to_ufs_host(rcdev);



	/* Currently this code only knows about a single reset. */

	WARN_ON(id);

	ufs_qcom_deassert_reset(host->hba);



	/*