Commit a98bf9df authored by Xu Panda's avatar Xu Panda Committed by Rob Herring
Browse files

of: base: use strscpy() to instead of strncpy() 



The implementation of strscpy() is more robust and safer.
That's now the recommended way to copy NUL terminated strings.

Signed-off-by: default avatarXu Panda <xu.panda@zte.com.cn>
Signed-off-by: default avatarYang Yang <yang.yang29@zte.com>
Link: https://lore.kernel.org/r/202212231039128402297@zte.com.cn


Signed-off-by: default avatarRob Herring <robh@kernel.org>
parent 00f2a08c

drivers/of/base.c

+1 −2
Original line number Diff line number Diff line
@@ -1884,8 +1884,7 @@ static void of_alias_add(struct alias_prop *ap, struct device_node *np, 
{

	ap->np = np;

	ap->id = id;

	strncpy(ap->stem, stem, stem_len);

	ap->stem[stem_len] = 0;

	strscpy(ap->stem, stem, stem_len + 1);

	list_add_tail(&ap->link, &aliases_lookup);

	pr_debug("adding DT alias:%s: stem=%s id=%i node=%pOF\n",

		 ap->alias, ap->stem, ap->id, np);