Commit a98151ad authored Mar 15, 2023 by Vlastimil Babka Committed by Steven Rostedt (Google) Mar 19, 2023

ring-buffer: remove obsolete comment for free_buffer_page()

The comment refers to mm/slob.c which is being removed. It comes from
commit ed56829c ("ring_buffer: reset buffer page when freeing") and
according to Steven the borrowed code was a page mapcount and mapping
reset, which was later removed by commit e4c2ce82 ("ring_buffer:
allocate buffer page pointer"). Thus the comment is not accurate anyway,
remove it.

Link: https://lore.kernel.org/linux-trace-kernel/20230315142446.27040-1-vbabka@suse.cz



Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>
Reported-by: Mike Rapoport <mike.rapoport@gmail.com>
Suggested-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Fixes: e4c2ce82 ("ring_buffer: allocate buffer page pointer")
Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
Reviewed-by: Mukesh Ojha <quic_mojha@quicinc.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>

parent e400be67

kernel/trace/ring_buffer.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -354,10 +354,6 @@ static void rb_init_page(struct buffer_data_page *bpage)
		local_set(&bpage->commit, 0);
		}

		/*
		* Also stolen from mm/slob.c. Thanks to Mathieu Desnoyers for pointing
		* this issue out.
		*/
		static void free_buffer_page(struct buffer_page *bpage)
		{
		free_page((unsigned long)bpage->page);