Commit a980755b authored by Ian Rogers's avatar Ian Rogers Committed by Arnaldo Carvalho de Melo
Browse files

perf build: Make BUILD_BPF_SKEL default, rename to NO_BPF_SKEL 



BPF skeleton support is now key to a number of perf features. Rather
than making it so that BPF support must be enabled for the build, make
this the default and error if the build lacks a clang and libbpf that
are sufficient. To avoid the error and build without BPF skeletons the
NO_BPF_SKEL=1 flag can be used. Add a build-options flag to 'perf
version' to enable detection of the BPF skeleton support and use this
in the offcpu shell test.

Signed-off-by: default avatarIan Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Leo Yan <leo.yan@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Martin Liška <mliska@suse.cz>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Nathan Chancellor <nathan@kernel.org>
Cc: Nick Desaulniers <ndesaulniers@google.com>
Cc: Pavithra Gurushankar <gpavithrasha@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Quentin Monnet <quentin@isovalent.com>
Cc: Roberto Sassu <roberto.sassu@huawei.com>
Cc: Stephane Eranian <eranian@google.com>
Cc: Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: Tom Rix <trix@redhat.com>
Cc: Yang Jihong <yangjihong1@huawei.com>
Cc: llvm@lists.linux.dev
Link: https://lore.kernel.org/r/20230311065753.3012826-2-irogers@google.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 7a9b223c

tools/perf/Makefile.config

+12 −7
Original line number Diff line number Diff line
@@ -415,6 +415,7 @@ ifdef NO_LIBELF 
  NO_LIBUNWIND := 1

  NO_LIBDW_DWARF_UNWIND := 1

  NO_LIBBPF := 1

  NO_BPF_SKEL := 1

  NO_JVMTI := 1

else

  ifeq ($(feature-libelf), 0)
@@ -662,19 +663,23 @@ ifndef NO_LIBBPF 
    msg := $(warning BPF API too old. Please install recent kernel headers. BPF support in 'perf record' is disabled.)

    NO_LIBBPF := 1

  endif

else

  NO_BPF_SKEL := 1

endif



ifdef BUILD_BPF_SKEL

ifndef NO_BPF_SKEL

  $(call feature_check,clang-bpf-co-re)

  ifeq ($(feature-clang-bpf-co-re), 0)

    dummy := $(error Error: clang too old/not installed. Please install recent clang to build with BUILD_BPF_SKEL)

  endif

    dummy := $(error: ERROR: BPF skeletons unsupported. clang too old/not installed or build with NO_BPF_SKEL=1.)

  else

    ifeq ($(filter -DHAVE_LIBBPF_SUPPORT, $(CFLAGS)),)

    dummy := $(error Error: BPF skeleton support requires libbpf)

  endif

      dummy := $(error: ERROR: BPF skeletons unsupported. BPF skeleton support requires libbpf or build with NO_BPF_SKEL=1.)

    else

      $(call detected,CONFIG_PERF_BPF_SKEL)

      CFLAGS += -DHAVE_BPF_SKEL

    endif

  endif

endif



dwarf-post-unwind := 1

dwarf-post-unwind-text := BUG

tools/perf/Makefile.perf

+4 −4
Original line number Diff line number Diff line
@@ -126,7 +126,7 @@ include ../scripts/utilities.mak 
#

# Define NO_LIBDEBUGINFOD if you do not want support debuginfod

#

# Define BUILD_BPF_SKEL to enable BPF skeletons

# Define NO_BPF_SKEL to disable BPF skeletons

#



# As per kernel Makefile, avoid funny character set dependencies
@@ -1055,7 +1055,7 @@ SKELETONS += $(SKEL_OUT)/kwork_trace.skel.h 
$(SKEL_TMP_OUT) $(LIBAPI_OUTPUT) $(LIBBPF_OUTPUT) $(LIBPERF_OUTPUT) $(LIBSUBCMD_OUTPUT) $(LIBSYMBOL_OUTPUT):

	$(Q)$(MKDIR) -p $@



ifdef BUILD_BPF_SKEL

ifndef NO_BPF_SKEL

BPFTOOL := $(SKEL_TMP_OUT)/bootstrap/bpftool

BPF_INCLUDE := -I$(SKEL_TMP_OUT)/.. -I$(LIBBPF_INCLUDE)
@@ -1088,11 +1088,11 @@ bpf-skel: $(SKELETONS) 


.PRECIOUS: $(SKEL_TMP_OUT)/%.bpf.o



else # BUILD_BPF_SKEL

else # NO_BPF_SKEL



bpf-skel:



endif # BUILD_BPF_SKEL

endif # NO_BPF_SKEL



bpf-skel-clean:

	$(call QUIET_CLEAN, bpf-skel) $(RM) -r $(SKEL_TMP_OUT) $(SKELETONS)

tools/perf/builtin-lock.c

+1 −1
Original line number Diff line number Diff line
@@ -2371,7 +2371,7 @@ int cmd_lock(int argc, const char **argv) 


#ifndef HAVE_BPF_SKEL

		set_option_nobuild(contention_options, 'b', "use-bpf",

				   "no BUILD_BPF_SKEL=1", false);

				   "NO_BPF_SKEL=1", false);

#endif

		if (argc) {

			argc = parse_options(argc, argv, contention_options,

tools/perf/builtin-record.c

+1 −1
Original line number Diff line number Diff line
@@ -3971,7 +3971,7 @@ int cmd_record(int argc, const char **argv) 


#ifndef HAVE_BPF_SKEL

# define set_nobuild(s, l, m, c) set_option_nobuild(record_options, s, l, m, c)

	set_nobuild('\0', "off-cpu", "no BUILD_BPF_SKEL=1", true);

	set_nobuild('\0', "off-cpu", "NO_BPF_SKEL=1", true);

# undef set_nobuild

#endif

tools/perf/builtin-version.c

+1 −0
Original line number Diff line number Diff line
@@ -83,6 +83,7 @@ static void library_status(void) 
	STATUS(HAVE_ZSTD_SUPPORT, zstd);

	STATUS(HAVE_LIBPFM, libpfm4);

	STATUS(HAVE_LIBTRACEEVENT, libtraceevent);

	STATUS(HAVE_BPF_SKEL, BPF skeletons);

}



int cmd_version(int argc, const char **argv)