Commit a97eb33f authored Feb 16, 2016 by Anton Protopopov Committed by David S. Miller Feb 19, 2016

rtnl: RTM_GETNETCONF: fix wrong return value



An error response from a RTM_GETNETCONF request can return the positive
error value EINVAL in the struct nlmsgerr that can mislead userspace.

Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com>
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent cfdd28be

net/ipv4/devinet.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1847,7 +1847,7 @@ static int inet_netconf_get_devconf(struct sk_buff *in_skb,
		if (err < 0)
		goto errout;

		err = EINVAL;
		err = -EINVAL;
		if (!tb[NETCONFA_IFINDEX])
		goto errout;

net/ipv6/addrconf.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -583,7 +583,7 @@ static int inet6_netconf_get_devconf(struct sk_buff *in_skb,
		if (err < 0)
		goto errout;

		err = EINVAL;
		err = -EINVAL;
		if (!tb[NETCONFA_IFINDEX])
		goto errout;