Commit a9712626 authored by Henning Schild's avatar Henning Schild Committed by Hans de Goede
Browse files

leds: simatic-ipc-leds-gpio: add new model 227G 



This adds support of the Siemens Simatic IPC227G. Its LEDs are connected
to GPIO pins provided by the gpio-f7188x module. We make sure that
gets loaded, if not enabled in the kernel config no LED support will be
available.

Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHenning Schild <henning.schild@siemens.com>
Link: https://lore.kernel.org/r/20220825104422.14156-6-henning.schild@siemens.com


Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 26d88a68

drivers/leds/simple/simatic-ipc-leds-gpio.c

+37 −5
Original line number Diff line number Diff line
@@ -13,28 +13,45 @@ 
#include <linux/leds.h>

#include <linux/module.h>

#include <linux/platform_device.h>

#include <linux/platform_data/x86/simatic-ipc-base.h>



static struct gpiod_lookup_table simatic_ipc_led_gpio_table = {

struct gpiod_lookup_table *simatic_ipc_led_gpio_table;



static struct gpiod_lookup_table simatic_ipc_led_gpio_table_127e = {

	.dev_id = "leds-gpio",

	.table = {

		GPIO_LOOKUP_IDX("apollolake-pinctrl.0", 51, NULL, 0, GPIO_ACTIVE_LOW),

		GPIO_LOOKUP_IDX("apollolake-pinctrl.0", 52, NULL, 1, GPIO_ACTIVE_LOW),

		GPIO_LOOKUP_IDX("apollolake-pinctrl.0", 53, NULL, 2, GPIO_ACTIVE_LOW),

		GPIO_LOOKUP_IDX("apollolake-pinctrl.0", 57, NULL, 3, GPIO_ACTIVE_LOW),

		GPIO_LOOKUP_IDX("apollolake-pinctrl.0", 58, NULL, 4, GPIO_ACTIVE_LOW),

		GPIO_LOOKUP_IDX("apollolake-pinctrl.0", 60, NULL, 5, GPIO_ACTIVE_LOW),

		GPIO_LOOKUP_IDX("apollolake-pinctrl.0", 51, NULL, 0, GPIO_ACTIVE_LOW),

		GPIO_LOOKUP_IDX("apollolake-pinctrl.0", 56, NULL, 6, GPIO_ACTIVE_LOW),

		GPIO_LOOKUP_IDX("apollolake-pinctrl.0", 59, NULL, 7, GPIO_ACTIVE_HIGH),

	},

};



static struct gpiod_lookup_table simatic_ipc_led_gpio_table_227g = {

	.dev_id = "leds-gpio",

	.table = {

		GPIO_LOOKUP_IDX("gpio-f7188x-2", 0, NULL, 0, GPIO_ACTIVE_LOW),

		GPIO_LOOKUP_IDX("gpio-f7188x-2", 1, NULL, 1, GPIO_ACTIVE_LOW),

		GPIO_LOOKUP_IDX("gpio-f7188x-2", 2, NULL, 2, GPIO_ACTIVE_LOW),

		GPIO_LOOKUP_IDX("gpio-f7188x-2", 3, NULL, 3, GPIO_ACTIVE_LOW),

		GPIO_LOOKUP_IDX("gpio-f7188x-2", 4, NULL, 4, GPIO_ACTIVE_LOW),

		GPIO_LOOKUP_IDX("gpio-f7188x-2", 5, NULL, 5, GPIO_ACTIVE_LOW),

		GPIO_LOOKUP_IDX("gpio-f7188x-3", 6, NULL, 6, GPIO_ACTIVE_HIGH),

		GPIO_LOOKUP_IDX("gpio-f7188x-3", 7, NULL, 7, GPIO_ACTIVE_HIGH),

	}

};



static const struct gpio_led simatic_ipc_gpio_leds[] = {

	{ .name = "green:" LED_FUNCTION_STATUS "-3" },

	{ .name = "red:" LED_FUNCTION_STATUS "-1" },

	{ .name = "green:" LED_FUNCTION_STATUS "-1" },

	{ .name = "red:" LED_FUNCTION_STATUS "-2" },

	{ .name = "green:" LED_FUNCTION_STATUS "-2" },

	{ .name = "red:" LED_FUNCTION_STATUS "-3" },

	{ .name = "green:" LED_FUNCTION_STATUS "-3" },

};



static const struct gpio_led_platform_data simatic_ipc_gpio_leds_pdata = {
@@ -46,7 +63,7 @@ static struct platform_device *simatic_leds_pdev; 


static int simatic_ipc_leds_gpio_remove(struct platform_device *pdev)

{

	gpiod_remove_lookup_table(&simatic_ipc_led_gpio_table);

	gpiod_remove_lookup_table(simatic_ipc_led_gpio_table);

	platform_device_unregister(simatic_leds_pdev);



	return 0;
@@ -54,10 +71,25 @@ static int simatic_ipc_leds_gpio_remove(struct platform_device *pdev) 


static int simatic_ipc_leds_gpio_probe(struct platform_device *pdev)

{

	const struct simatic_ipc_platform *plat = pdev->dev.platform_data;

	struct gpio_desc *gpiod;

	int err;



	gpiod_add_lookup_table(&simatic_ipc_led_gpio_table);

	switch (plat->devmode) {

	case SIMATIC_IPC_DEVICE_127E:

		simatic_ipc_led_gpio_table = &simatic_ipc_led_gpio_table_127e;

		break;

	case SIMATIC_IPC_DEVICE_227G:

		if (!IS_ENABLED(CONFIG_GPIO_F7188X))

			return -ENODEV;

		request_module("gpio-f7188x");

		simatic_ipc_led_gpio_table = &simatic_ipc_led_gpio_table_227g;

		break;

	default:

		return -ENODEV;

	}



	gpiod_add_lookup_table(simatic_ipc_led_gpio_table);

	simatic_leds_pdev = platform_device_register_resndata(NULL,

		"leds-gpio", PLATFORM_DEVID_NONE, NULL, 0,

		&simatic_ipc_gpio_leds_pdata,

drivers/platform/x86/simatic-ipc.c

+3 −1
Original line number Diff line number Diff line
@@ -41,6 +41,7 @@ static struct { 
	{SIMATIC_IPC_IPC127E, SIMATIC_IPC_DEVICE_127E, SIMATIC_IPC_DEVICE_NONE},

	{SIMATIC_IPC_IPC227D, SIMATIC_IPC_DEVICE_227D, SIMATIC_IPC_DEVICE_NONE},

	{SIMATIC_IPC_IPC227E, SIMATIC_IPC_DEVICE_427E, SIMATIC_IPC_DEVICE_227E},

	{SIMATIC_IPC_IPC227G, SIMATIC_IPC_DEVICE_227G, SIMATIC_IPC_DEVICE_NONE},

	{SIMATIC_IPC_IPC277E, SIMATIC_IPC_DEVICE_NONE, SIMATIC_IPC_DEVICE_227E},

	{SIMATIC_IPC_IPC427D, SIMATIC_IPC_DEVICE_427E, SIMATIC_IPC_DEVICE_NONE},

	{SIMATIC_IPC_IPC427E, SIMATIC_IPC_DEVICE_427E, SIMATIC_IPC_DEVICE_427E},
@@ -65,7 +66,8 @@ static int register_platform_devices(u32 station_id) 
	}



	if (ledmode != SIMATIC_IPC_DEVICE_NONE) {

		if (ledmode == SIMATIC_IPC_DEVICE_127E)

		if (ledmode == SIMATIC_IPC_DEVICE_127E ||

		    ledmode == SIMATIC_IPC_DEVICE_227G)

			pdevname = KBUILD_MODNAME "_leds_gpio";

		platform_data.devmode = ledmode;

		ipc_led_platform_device =

include/linux/platform_data/x86/simatic-ipc-base.h

+1 −0
Original line number Diff line number Diff line
@@ -19,6 +19,7 @@ 
#define SIMATIC_IPC_DEVICE_427E 2

#define SIMATIC_IPC_DEVICE_127E 3

#define SIMATIC_IPC_DEVICE_227E 4

#define SIMATIC_IPC_DEVICE_227G 5



struct simatic_ipc_platform {

	u8	devmode;

include/linux/platform_data/x86/simatic-ipc.h

+1 −0
Original line number Diff line number Diff line
@@ -31,6 +31,7 @@ enum simatic_ipc_station_ids { 
	SIMATIC_IPC_IPC427E = 0x00000A01,

	SIMATIC_IPC_IPC477E = 0x00000A02,

	SIMATIC_IPC_IPC127E = 0x00000D01,

	SIMATIC_IPC_IPC227G = 0x00000F01,

};



static inline u32 simatic_ipc_get_station_id(u8 *data, int max_len)