Commit a959a978 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Al Viro
Browse files

iov_iter: fix the uaccess area in copy_compat_iovec_from_user 



sizeof needs to be called on the compat pointer, not the native one.

Fixes: 89cd35c5 ("iov_iter: transparently handle compat iovecs in import_iovec")
Reported-by: default avatarDavid Laight <David.Laight@ACULAB.COM>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent a0a6df9a

lib/iov_iter.c

+1 −1
Original line number Diff line number Diff line
@@ -1658,7 +1658,7 @@ static int copy_compat_iovec_from_user(struct iovec *iov, 
		(const struct compat_iovec __user *)uvec;

	int ret = -EFAULT, i;



	if (!user_access_begin(uvec, nr_segs * sizeof(*uvec)))

	if (!user_access_begin(uiov, nr_segs * sizeof(*uiov)))

		return -EFAULT;



	for (i = 0; i < nr_segs; i++) {