Unverified Commit a91e5e3e authored by Maxime Ripard's avatar Maxime Ripard
Browse files

drm/connector: Set DDC pointer in drmm_connector_init 



Commit 35a3b82f ("drm/connector: Introduce drmm_connector_init")
introduced the function drmm_connector_init() with a parameter for an
optional ddc pointer to the i2c controller used to access the DDC bus.

However, the underlying call to __drm_connector_init() was always
setting it to NULL instead of passing the ddc argument around.

This resulted in unexpected null pointer dereference on platforms
expecting to get a DDC controller.

Fixes: 35a3b82f ("drm/connector: Introduce drmm_connector_init")
Reviewed-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Link: https://lore.kernel.org/r/20221019143442.1798964-1-maxime@cerno.tech


Signed-off-by: default avatarMaxime Ripard <maxime@cerno.tech>
parent 70890033

drivers/gpu/drm/drm_connector.c

+1 −1
Original line number Diff line number Diff line
@@ -435,7 +435,7 @@ int drmm_connector_init(struct drm_device *dev, 
	if (drm_WARN_ON(dev, funcs && funcs->destroy))

		return -EINVAL;



	ret = __drm_connector_init(dev, connector, funcs, connector_type, NULL);

	ret = __drm_connector_init(dev, connector, funcs, connector_type, ddc);

	if (ret)

		return ret;