Commit a8ea4273 authored by Liang He's avatar Liang He Committed by Stephen Boyd
Browse files

clk: qoriq: Hold reference returned by of_get_parent() 



In legacy_init_clockgen(), we need to hold the reference returned
by of_get_parent() and use it to call of_node_put() for refcount
balance.

Beside, in create_sysclk(), we need to call of_node_put() on 'sysclk'
also for refcount balance.

Fixes: 0dfc86b3 ("clk: qoriq: Move chip-specific knowledge into driver")
Signed-off-by: default avatarLiang He <windhl@126.com>
Link: https://lore.kernel.org/r/20220628143851.171299-1-windhl@126.com


Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent 1d6aa08c

drivers/clk/clk-qoriq.c

+8 −2
Original line number Diff line number Diff line
@@ -1063,8 +1063,13 @@ static void __init _clockgen_init(struct device_node *np, bool legacy); 
 */

static void __init legacy_init_clockgen(struct device_node *np)

{

	if (!clockgen.node)

		_clockgen_init(of_get_parent(np), true);

	if (!clockgen.node) {

		struct device_node *parent_np;



		parent_np = of_get_parent(np);

		_clockgen_init(parent_np, true);

		of_node_put(parent_np);

	}

}



/* Legacy node */
@@ -1159,6 +1164,7 @@ static struct clk * __init create_sysclk(const char *name) 
	sysclk = of_get_child_by_name(clockgen.node, "sysclk");

	if (sysclk) {

		clk = sysclk_from_fixed(sysclk, name);

		of_node_put(sysclk);

		if (!IS_ERR(clk))

			return clk;

	}