Commit a8e98f34 authored Feb 25, 2023 by Dmitry Fomin Committed by Takashi Iwai Mar 03, 2023

ALSA: ice1712: Delete unreachable code in aureon_add_controls()



If the check (id != 0x41) fails, then id == 0x41 and
the other check in 'else' branch also
fails: id & 0x0F = 0b01000001 & 0b00001111 = 0b00000001.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Signed-off-by: Dmitry Fomin <fomindmitriyfoma@mail.ru>
Link: https://lore.kernel.org/r/20230225184322.6286-2-fomindmitriyfoma@mail.ru


Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 951606a1

sound/pci/ice1712/aureon.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -1896,10 +1896,6 @@ static int aureon_add_controls(struct snd_ice1712 *ice)
		if (id != 0x41)
		dev_info(ice->card->dev,
		"No CS8415 chip. Skipping CS8415 controls.\n");
		else if ((id & 0x0F) != 0x01)
		dev_info(ice->card->dev,
		"Detected unsupported CS8415 rev. (%c)\n",
		(char)((id & 0x0F) + 'A' - 1));
		else {
		for (i = 0; i < ARRAY_SIZE(cs8415_controls); i++) {
		struct snd_kcontrol *kctl;