Unverified Commit a8d5df69 authored by Liang He's avatar Liang He Committed by Mark Brown
Browse files

ASoC: mt6359: Fix refcount leak bug 



In mt6359_parse_dt() and mt6359_accdet_parse_dt(), we should call
of_node_put() for the reference returned by of_get_child_by_name()
which has increased the refcount.

Fixes: 68353028 ("ASoC: mt6359: fix failed to parse DT properties")
Fixes: eef07b9e ("ASoC: mediatek: mt6359: add MT6359 accdet jack driver")
Signed-off-by: default avatarLiang He <windhl@126.com>
Link: https://lore.kernel.org/r/20220713102013.367336-1-windhl@126.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 1795c16a

sound/soc/codecs/mt6359-accdet.c

+1 −0
Original line number Diff line number Diff line
@@ -675,6 +675,7 @@ static int mt6359_accdet_parse_dt(struct mt6359_accdet *priv) 
			       sizeof(struct three_key_threshold));

	}



	of_node_put(node);

	dev_warn(priv->dev, "accdet caps=%x\n", priv->caps);



	return 0;

sound/soc/codecs/mt6359.c

+1 −0
Original line number Diff line number Diff line
@@ -2778,6 +2778,7 @@ static int mt6359_parse_dt(struct mt6359_priv *priv) 


	ret = of_property_read_u32(np, "mediatek,mic-type-2",

				   &priv->mux_select[MUX_MIC_TYPE_2]);

	of_node_put(np);

	if (ret) {

		dev_info(priv->dev,

			 "%s() failed to read mic-type-2, use default (%d)\n",