Commit a8c2038f authored by Fabio Estevam's avatar Fabio Estevam Committed by Bjorn Helgaas
Browse files

PCI: qcom: Use gpiod_set_value_cansleep() to allow reset via expanders 



The reset GPIO can be connected to a I2C or SPI IO expander, which may
sleep, so it is safer to use the gpiod_set_value_cansleep() variant
instead.

Signed-off-by: default avatarFabio Estevam <fabio.estevam@nxp.com>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Acked-by: default avatarStanimir Varbanov <svarbanov@mm-sol.com>
parent 8c934095

drivers/pci/dwc/pcie-qcom.c

+2 −2
Original line number Diff line number Diff line
@@ -142,13 +142,13 @@ struct qcom_pcie { 


static void qcom_ep_reset_assert(struct qcom_pcie *pcie)

{

	gpiod_set_value(pcie->reset, 1);

	gpiod_set_value_cansleep(pcie->reset, 1);

	usleep_range(PERST_DELAY_US, PERST_DELAY_US + 500);

}



static void qcom_ep_reset_deassert(struct qcom_pcie *pcie)

{

	gpiod_set_value(pcie->reset, 0);

	gpiod_set_value_cansleep(pcie->reset, 0);

	usleep_range(PERST_DELAY_US, PERST_DELAY_US + 500);

}