Commit a8b89c10 authored by Liang He's avatar Liang He Committed by Michael Ellerman
Browse files

powerpc/85xx: Add missing of_node_get/put() in ge_imp3a_pci_assign_primary() 



for_each_node_by_type() will automatically increase and decrease
the refcount during the iteration. However, there is a reference
escaped into global 'fsl_pci_primary' and we need to handle it.

Signed-off-by: default avatarLiang He <windhl@126.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220701140119.245435-1-windhl@126.com
parent 9d86f091

arch/powerpc/platforms/85xx/ge_imp3a.c

+4 −2
Original line number Diff line number Diff line
@@ -89,8 +89,10 @@ static void __init ge_imp3a_pci_assign_primary(void) 
		    of_device_is_compatible(np, "fsl,mpc8548-pcie") ||

		    of_device_is_compatible(np, "fsl,p2020-pcie")) {

			of_address_to_resource(np, 0, &rsrc);

			if ((rsrc.start & 0xfffff) == 0x9000)

				fsl_pci_primary = np;

			if ((rsrc.start & 0xfffff) == 0x9000) {

				of_node_put(fsl_pci_primary);

				fsl_pci_primary = of_node_get(np);

			}

		}

	}

#endif