Commit a8aedd45 authored by Baokun Li's avatar Baokun Li Committed by Hans de Goede
Browse files

platform/surface: aggregator: Use list_move_tail instead of... 


platform/surface: aggregator: Use list_move_tail instead of list_del/list_add_tail in ssh_request_layer.c

Using list_move_tail() instead of list_del() + list_add_tail() in ssh_request_layer.c.

Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarBaokun Li <libaokun1@huawei.com>
Reviewed-by: default avatarMaximilian Luz <luzmaximilian@gmail.com>
Link: https://lore.kernel.org/r/20210609072638.1358174-1-libaokun1@huawei.com


Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent f9e7f9a2

drivers/platform/surface/aggregator/ssh_request_layer.c

+3 −7
Original line number Diff line number Diff line
@@ -863,9 +863,7 @@ static void ssh_rtl_timeout_reap(struct work_struct *work) 
		clear_bit(SSH_REQUEST_SF_PENDING_BIT, &r->state);



		atomic_dec(&rtl->pending.count);

		list_del(&r->node);



		list_add_tail(&r->node, &claimed);

		list_move_tail(&r->node, &claimed);

	}

	spin_unlock(&rtl->pending.lock);
@@ -1204,8 +1202,7 @@ void ssh_rtl_shutdown(struct ssh_rtl *rtl) 
		smp_mb__before_atomic();

		clear_bit(SSH_REQUEST_SF_QUEUED_BIT, &r->state);



		list_del(&r->node);

		list_add_tail(&r->node, &claimed);

		list_move_tail(&r->node, &claimed);

	}

	spin_unlock(&rtl->queue.lock);
@@ -1238,8 +1235,7 @@ void ssh_rtl_shutdown(struct ssh_rtl *rtl) 
			smp_mb__before_atomic();

			clear_bit(SSH_REQUEST_SF_PENDING_BIT, &r->state);



			list_del(&r->node);

			list_add_tail(&r->node, &claimed);

			list_move_tail(&r->node, &claimed);

		}

		spin_unlock(&rtl->pending.lock);

	}