Unverified Commit a8ae15ea authored by Alviro Iskandar Setiawan's avatar Alviro Iskandar Setiawan Committed by Mark Brown
Browse files

ASoC: atmel: mchp-pdmc: Fix `-Wpointer-bool-conversion` warning 



In function mchp_pdmc_af_put(), Intel's kernel test robot reports the
following warning:

  sound/soc/atmel/mchp-pdmc.c:186:34: warning: address of array \
  'uvalue->value.integer.value' will always evaluate to 'true' \
  [-Wpointer-bool-conversion]

This is because we are using `uvalue->value.integer.value` which its
type is `long value[128];` for conditional expression and that array
will always decay to a non-NULL pointer. Using a non-NULL pointer for
conditional expression will always evaluate to true.

Fix this by changing it to `uvalue->value.integer.value[0]` as that's
what the mchp_pdmc_af_get() function sets.

Reported-by: default avatarkernel test robot <lkp@intel.com>
Reviewed-by: default avatarCodrin Ciubotariu <codrin.ciubotariu@microchip.com>
Reviewed-by: default avatarNathan Chancellor <nathan@kernel.org>
Signed-off-by: default avatarAlviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
Link: https://lore.kernel.org/r/20220315001848.3763534-1-alviro.iskandar@gnuweeb.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 910f42bf

sound/soc/atmel/mchp-pdmc.c

+1 −1
Original line number Diff line number Diff line
@@ -183,7 +183,7 @@ static int mchp_pdmc_af_put(struct snd_kcontrol *kcontrol, 
{

	struct snd_soc_component *component = snd_kcontrol_chip(kcontrol);

	struct mchp_pdmc *dd = snd_soc_component_get_drvdata(component);

	bool af = uvalue->value.integer.value ? true : false;

	bool af = uvalue->value.integer.value[0] ? true : false;



	if (dd->audio_filter_en == af)

		return 0;