Commit a8867f4e authored by Phillip Potter's avatar Phillip Potter Committed by Theodore Ts'o
Browse files

ext4: fix memory leak in ext4_mb_init_backend on error path. 



Fix a memory leak discovered by syzbot when a file system is corrupted
with an illegally large s_log_groups_per_flex.

Reported-by: default avatar <syzbot+aa12d6106ea4ca1b6aae@syzkaller.appspotmail.com>
Signed-off-by: default avatarPhillip Potter <phil@philpotter.co.uk>
Cc: stable@kernel.org
Link: https://lore.kernel.org/r/20210412073837.1686-1-phil@philpotter.co.uk


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent 6c091273

fs/ext4/mballoc.c

+1 −1
Original line number Diff line number Diff line
@@ -3217,7 +3217,7 @@ static int ext4_mb_init_backend(struct super_block *sb) 
		 */

		if (sbi->s_es->s_log_groups_per_flex >= 32) {

			ext4_msg(sb, KERN_ERR, "too many log groups per flexible block group");

			goto err_freesgi;

			goto err_freebuddy;

		}

		sbi->s_mb_prefetch = min_t(uint, 1 << sbi->s_es->s_log_groups_per_flex,

			BLK_MAX_SEGMENT_SIZE >> (sb->s_blocksize_bits - 9));