Commit a886001c authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Jens Axboe
Browse files

block: don't call blk_throtl_stat_add for non-READ/WRITE commands 



blk_throtl_stat_add is called from blk_stat_add explicitly, unlike the
other stats that go through q->stats->callbacks.  To prepare for cgroup
data moving to the gendisk, ensure blk_throtl_stat_add is only called
for the plain READ and WRITE commands that it actually handles internally,
as blk_stat_add can also be called for passthrough commands on queues that
do not have a gendisk associated with them.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarAndreas Herrmann <aherrmann@suse.de>
Acked-by: default avatarTejun Heo <tj@kernel.org>
Link: https://lore.kernel.org/r/20230203150400.3199230-2-hch@lst.de


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 839c717b

block/blk-stat.c

+2 −1
Original line number Diff line number Diff line
@@ -58,6 +58,7 @@ void blk_stat_add(struct request *rq, u64 now) 


	value = (now >= rq->io_start_time_ns) ? now - rq->io_start_time_ns : 0;



	if (req_op(rq) == REQ_OP_READ || req_op(rq) == REQ_OP_WRITE)

		blk_throtl_stat_add(rq, value);



	rcu_read_lock();