Commit a872ab4d authored by Jiri Slaby's avatar Jiri Slaby Committed by Greg Kroah-Hartman
Browse files

tty: let tty_unregister_driver return void 



Now that noone checks the return value, switch the return type of
tty_unregister_driver to void. We can do that as we always return zero.

Generally, drivers are not allowed to call tty_unregister_driver while
there are open devices.

Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
Link: https://lore.kernel.org/r/20210302062214.29627-35-jslaby@suse.cz


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6c2e6317

drivers/tty/tty_io.c

+1 −8
Original line number Diff line number Diff line
@@ -3525,21 +3525,14 @@ EXPORT_SYMBOL(tty_register_driver); 
/*

 * Called by a tty driver to unregister itself.

 */

int tty_unregister_driver(struct tty_driver *driver)

void tty_unregister_driver(struct tty_driver *driver)

{

#if 0

	/* FIXME */

	if (driver->refcount)

		return -EBUSY;

#endif

	unregister_chrdev_region(MKDEV(driver->major, driver->minor_start),

				driver->num);

	mutex_lock(&tty_mutex);

	list_del(&driver->tty_drivers);

	mutex_unlock(&tty_mutex);

	return 0;

}



EXPORT_SYMBOL(tty_unregister_driver);



dev_t tty_devnum(struct tty_struct *tty)

include/linux/tty.h

+1 −1
Original line number Diff line number Diff line
@@ -482,7 +482,7 @@ extern void stop_tty(struct tty_struct *tty); 
extern void __start_tty(struct tty_struct *tty);

extern void start_tty(struct tty_struct *tty);

extern int tty_register_driver(struct tty_driver *driver);

extern int tty_unregister_driver(struct tty_driver *driver);

extern void tty_unregister_driver(struct tty_driver *driver);

extern struct device *tty_register_device(struct tty_driver *driver,

					  unsigned index, struct device *dev);

extern struct device *tty_register_device_attr(struct tty_driver *driver,