Commit a871afc8 authored by Lyude Paul's avatar Lyude Paul Committed by Alex Deucher
Browse files

drm/amd/dc: Kill dc_conn_log_hex_linux() 



DRM already supports tracing DPCD transactions, there's no reason for
the existence of this function. Also, it prints one byte per-line which
is way too loud. So, just remove it.

Reviewed-by: default avatarNicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: default avatarLyude Paul <lyude@redhat.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent a98c4cd9

drivers/gpu/drm/amd/display/dc/basics/Makefile

+1 −2
Original line number Diff line number Diff line
@@ -24,8 +24,7 @@ 
# It provides the general basic services required by other DAL

# subcomponents.



BASICS = conversion.o fixpt31_32.o \

	log_helpers.o vector.o dc_common.o

BASICS = conversion.o fixpt31_32.o vector.o dc_common.o



AMD_DAL_BASICS = $(addprefix $(AMDDALPATH)/dc/basics/,$(BASICS))

drivers/gpu/drm/amd/display/dc/basics/log_helpers.c

deleted100644 → 0
+0 −39
Original line number Diff line number Diff line 
/*

 * Copyright 2012-16 Advanced Micro Devices, Inc.

 *

 * Permission is hereby granted, free of charge, to any person obtaining a

 * copy of this software and associated documentation files (the "Software"),

 * to deal in the Software without restriction, including without limitation

 * the rights to use, copy, modify, merge, publish, distribute, sublicense,

 * and/or sell copies of the Software, and to permit persons to whom the

 * Software is furnished to do so, subject to the following conditions:

 *

 * The above copyright notice and this permission notice shall be included in

 * all copies or substantial portions of the Software.

 *

 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR

 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,

 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL

 * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR

 * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,

 * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR

 * OTHER DEALINGS IN THE SOFTWARE.

 *

 * Authors: AMD

 *

 */



#include "core_types.h"

#include "logger.h"

#include "include/logger_interface.h"

#include "dm_helpers.h"



void dc_conn_log_hex_linux(const uint8_t *hex_data, int hex_data_count)

{

	int i;



	if (hex_data)

		for (i = 0; i < hex_data_count; i++)

			DC_LOG_DEBUG("%2.2X ", hex_data[i]);

}

drivers/gpu/drm/amd/display/include/logger_interface.h

+0 −4
Original line number Diff line number Diff line
@@ -40,8 +40,6 @@ struct dc_state; 
 *

 */



void dc_conn_log_hex_linux(const uint8_t *hex_data, int hex_data_count);



void pre_surface_trace(

		struct dc *dc,

		const struct dc_plane_state *const *plane_states,
@@ -102,14 +100,12 @@ void context_clock_trace( 
#define CONN_DATA_DETECT(link, hex_data, hex_len, ...) \

		do { \

			(void)(link); \

			dc_conn_log_hex_linux(hex_data, hex_len); \

			DC_LOG_EVENT_DETECTION(__VA_ARGS__); \

		} while (0)



#define CONN_DATA_LINK_LOSS(link, hex_data, hex_len, ...) \

		do { \

			(void)(link); \

			dc_conn_log_hex_linux(hex_data, hex_len); \

			DC_LOG_EVENT_LINK_LOSS(__VA_ARGS__); \

		} while (0)