Commit a855724d authored by Mario Limonciello's avatar Mario Limonciello Committed by Linus Walleij
Browse files

pinctrl: amd: Fix mistake in handling clearing pins at startup 

commit 4e5a04be ("pinctrl: amd: disable and mask interrupts on probe")
had a mistake in loop iteration 63 that it would clear offset 0xFC instead
of 0x100.  Offset 0xFC is actually `WAKE_INT_MASTER_REG`.  This was
clearing bits 13 and 15 from the register which significantly changed the
expected handling for some platforms for GPIO0.

Cc: stable@vger.kernel.org
Link: https://bugzilla.kernel.org/show_bug.cgi?id=217315


Signed-off-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Link: https://lore.kernel.org/r/20230421120625.3366-3-mario.limonciello@amd.com


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 968ab926

drivers/pinctrl/pinctrl-amd.c

+2 −2
Original line number Diff line number Diff line
@@ -897,9 +897,9 @@ static void amd_gpio_irq_init(struct amd_gpio *gpio_dev) 


		raw_spin_lock_irqsave(&gpio_dev->lock, flags);



		pin_reg = readl(gpio_dev->base + i * 4);

		pin_reg = readl(gpio_dev->base + pin * 4);

		pin_reg &= ~mask;

		writel(pin_reg, gpio_dev->base + i * 4);

		writel(pin_reg, gpio_dev->base + pin * 4);



		raw_spin_unlock_irqrestore(&gpio_dev->lock, flags);

	}