Commit a846738f authored by Jan Beulich's avatar Jan Beulich Committed by Juergen Gross
Browse files

xen-blkback: don't leak persistent grants from xen_blkbk_map() 



The fix for XSA-365 zapped too many of the ->persistent_gnt[] entries.
Ones successfully obtained should not be overwritten, but instead left
for xen_blkbk_unmap_prepare() to pick up and put.

This is XSA-371.

Signed-off-by: default avatarJan Beulich <jbeulich@suse.com>
Cc: stable@vger.kernel.org
Reviewed-by: default avatarJuergen Gross <jgross@suse.com>
Reviewed-by: default avatarWei Liu <wl@xen.org>
Signed-off-by: default avatarJuergen Gross <jgross@suse.com>
parent af44a387

drivers/block/xen-blkback/blkback.c

+1 −1
Original line number Diff line number Diff line
@@ -891,7 +891,7 @@ static int xen_blkbk_map(struct xen_blkif_ring *ring, 
out:

	for (i = last_map; i < num; i++) {

		/* Don't zap current batch's valid persistent grants. */

		if(i >= last_map + segs_to_map)

		if(i >= map_until)

			pages[i]->persistent_gnt = NULL;

		pages[i]->handle = BLKBACK_INVALID_HANDLE;

	}