Commit a840974e authored by Thomas Richter's avatar Thomas Richter Committed by Arnaldo Carvalho de Melo
Browse files

perf test: Test 73 Sig_trap fails on s390 



In Linux next commit 5504f679 ("perf test sigtrap: Add basic
stress test for sigtrap handling") introduced the new test which uses
breakpoint events.  These events are not supported on s390 and PowerPC
and always fail:

  # perf test -F 73
  73: Sigtrap                                                         : FAILED!
  #

Fix it the same way as in the breakpoint tests in file
tests/bp_account.c where these type of tests are skipped on s390 and
PowerPC platforms.

With this patch skip this test on both platforms.

Output after:

  # perf test -F 73
  73: Sigtrap
  #

Fixes: 5504f679 ("perf test sigtrap: Add basic stress test for sigtrap handling")
Signed-off-by: default avatarThomas Richter <tmricht@linux.ibm.com>
Acked-by: default avatarMarco Elver <elver@google.com>
Cc: Heiko Carstens <hca@linux.ibm.com>
Cc: Sumanth Korikkar <sumanthk@linux.ibm.com>
Cc: Sven Schnelle <svens@linux.ibm.com>
Cc: Vasily Gorbik <gor@linux.ibm.com>
Link: https://lore.kernel.org/r/20211216151454.752066-1-tmricht@linux.ibm.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 9c5c6052

tools/perf/tests/sigtrap.c

+18 −0
Original line number Diff line number Diff line
@@ -22,6 +22,19 @@ 
#include "tests.h"

#include "../perf-sys.h"



/*

 * PowerPC and S390 do not support creation of instruction breakpoints using the

 * perf_event interface.

 *

 * Just disable the test for these architectures until these issues are

 * resolved.

 */

#if defined(__powerpc__) || defined(__s390x__)

#define BP_ACCOUNT_IS_SUPPORTED 0

#else

#define BP_ACCOUNT_IS_SUPPORTED 1

#endif



#define NUM_THREADS 5



static struct {
@@ -122,6 +135,11 @@ static int test__sigtrap(struct test_suite *test __maybe_unused, int subtest __m 
	char sbuf[STRERR_BUFSIZE];

	int i, fd, ret = TEST_FAIL;



	if (!BP_ACCOUNT_IS_SUPPORTED) {

		pr_debug("Test not supported on this architecture");

		return TEST_SKIP;

	}



	pthread_barrier_init(&barrier, NULL, NUM_THREADS + 1);



	action.sa_flags = SA_SIGINFO | SA_NODEFER;